scp: add flag to notify for uploading finished when uploaded an empty file #1658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thegame4craft
requested review from
drieseng,
WojciechNagorski and
Rob-Hague
as code owners
Rob-Hague
reviewed
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new flag:
notifyOnEmptyFile(default:false).Details
* This flag controls whether the
Uploadingevent should be triggered when an uploaded file is empty (totalLength== 0).* When enabled and the uploaded file is empty, the
Uploadingevent will still be raised.* This behavior is currently implemented only for SCP uploads.
Use Case
I’m building a simple .NET Framework application that uploads configuration files to an SSH server. Each upload triggers a log entry via the Uploading event. However, empty files were previously ignored, and no log was written. With this change, the log will accurately reflect all upload attempts — including empty files — when the flag is enabled.